[jdk18] RFR: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 [v2]

[Valerie Peng]

On Thu, 23 Dec 2021 13:42:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8279222-jsp-get
>>  - Fix
>
> src/java.base/share/classes/java/security/Provider.java line 1152:
> 
>> 1150:                 case ADD:
>> 1151:                     // clean up old alias if present
>> 1152:                     Service prevAliasService = legacyMap.get(aliasKey);
> 
> The change looks okay but I'm surprised this wasn't caught by tests. 
> @valeriepeng - would it be feasible to have a test that removes an old alias so that this code is exercised by tests?

Hmm, this "ADD" case should be covered by existing regression tests. I will take a look. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk18/pull/70