RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v6]

[Weijun Wang]

On Mon, 1 Feb 2021 11:41:02 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>> 
>>  - move test
>>  - Merge branch 'master' into 8257858
>>  - a test
>>    
>>    only in patch2:
>>    unchanged:
>>  - end values should be vectors
>>  - phil comment
>>  - same behavior as before -- empty realm map
>>  - error check, new JavaStringToNSString
>>  - do not find class and method in loop
>>  - no more header file
>>    
>>    reverted:
>>  - better macro, no more JNI_COCOA_ENTER
>>  - ... and 5 more: https://git.openjdk.java.net/jdk/compare/81433b38...ef337f12
>
> make/test/JtregNativeJdk.gmk line 84:
> 
>> 82:       -framework Cocoa -framework JavaNativeFoundation
>> 83:   BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeJniInvocationTest := -ljli
>> 84:   BUILD_JDK_JTREG_LIBRARIES_CFLAGS_libTestDynamicStore := -ObjC
> 
> Instead of "tricking" the build system of compiling an Obj-C file by masquerading it as a C file and passing compiler options, you should expose the test file for what it is, and add support in the build system to handle this. I can help you with that part.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1845