RFR: 8211227: Inconsistent TLS protocol version in debug output

Rajan Halade rhalade at openjdk.java.net
Mon Feb 1 19:43:43 UTC 2021


On Mon, 1 Feb 2021 10:37:35 GMT, Evan Whelan <ewhelan at openjdk.org> wrote:

> Hi everyone,
> 
> Please review my fix for JDK-8211227
> 
> This supportability fix will result in a more consistent debug format when reading and writing TLS protocol versions.
> 
> Thanks,
> Evan

Changes requested by rhalade (Reviewer).

test/jdk/sun/security/ssl/SSLLogger/LoggingFormatConsistency.java line 36:

> 34: /*
> 35:  * This test runs in another process so we can monitor the debug
> 36:  * results.  The OutputAnalyzer must see correct debug output to return a

Suggestion:

 * results. The OutputAnalyzer must see correct debug output to return a

test/jdk/sun/security/ssl/SSLLogger/LoggingFormatConsistency.java line 83:

> 81:         // Re-enabling as test depends on these algorithms
> 82:         SecurityUtils.removeFromDisabledTlsAlgs("TLSv1", "TLSv1.1");
> 83:         var url = new URL("https://jpg-data.us.oracle.com/");

This URL is not accessible outside.

test/jdk/sun/security/ssl/SSLLogger/LoggingFormatConsistency.java line 50:

> 48: public class LoggingFormatConsistency {
> 49:     public static void main(String[] args) throws Exception {
> 50:         if (args.length == 0){

Please add a comment to explain when the test should be run with parameter.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2331


More information about the security-dev mailing list