RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

Andrew Haley aph at openjdk.java.net
Wed Feb 3 09:25:52 UTC 2021


On Tue, 2 Feb 2021 18:03:50 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5271:
> 
>> 5269: //
>> 5270: void MacroAssembler::get_thread(Register dst) {
>> 5271:   RegSet saved_regs = RegSet::range(r0, r1) + BSD_ONLY(RegSet::range(r2, r17)) + lr - dst;
> 
> The comment needs to be updated, since on BSD we also seem to clobber r2,r17 ?

Surely this should be 

 saved_regs = RegSet::range(r0, r1) BSD_ONLY(+ RegSet::range(r2, r17)) + lr - dst;```

Shouldn't it?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200



More information about the security-dev mailing list