RFR: 8163498: Many long-running security libs tests [v3]

[Weijun Wang]

On Wed, 3 Feb 2021 22:24:03 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

>> The following tests have been split based on lower/higher key sizes in order to reduce individual execution time and run in parallel with jtreg
>> sun/security/provider/DSA/SupportedDSAParamGen.java
>> sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java
>> com/sun/crypto/provider/KeyAgreement/SupportedDHParamGens.java
>> 
>> sun/security/rsa/SignatureTest.java is now using a fake generator since its objective is to test signature not key generation itself. In addition, it was generating and verifying the same key twice, with same modulus and exponent. That redundancy is removed. This speeds up the execution from ~54s to ~25s on average
>
> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add key itself to signature verification

New structure looks good.

test/jdk/sun/security/provider/NSASuiteB/TestDSAGenParameterSpecLongKey.java line 30:

> 28:  *          DSA within some certain range of key sizes as described in the class
> 29:  *          specification (L, N) as (1024, 160), (2048, 224), (2048, 256) and
> 30:  *          (3072, 256) should be OK for DSAGenParameterSpec.

Please modify the `@summary` to match what this test does.

test/jdk/sun/security/rsa/SignatureTest.java line 145:

> 143:                 Asserts.assertTrue(keySpecEquals(pubKeySpec1, pubKeySpec2),
> 144:                         "Both RSAPublicKeySpec should be equal");
> 145: 

Do you also want to add similar check on X509EncodedKeySpec? Same for PKCS8EncodedKeySpec below.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2381