RFR: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset [v4]

Fernando Guallini fguallini at openjdk.java.net
Thu Feb 11 12:45:40 UTC 2021


On Thu, 11 Feb 2021 12:17:41 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   check exception type
>
> test/jdk/javax/net/ssl/SSLSession/TestEnabledProtocols.java line 155:
> 
>> 153:                 && "Connection reset".equals(cause.getMessage())) {
>> 154:             System.out.println("Client SSLException:");
>> 155:             ssle.printStackTrace(System.out);
> 
> Sorry for nit picking - but I would keep that tracing in the catch clause above. 
> 
>         } catch (SSLException ssle) {
>             if (isConnectionReset(ssle)) {
>                 System.out.println("Client SSLException:");
>                 ssle.printStackTrace(System.out);
>             } else {
>                  failTest(ssle, "Client got UNEXPECTED SSLException:");
>             }
>         }
>  ```

That is perfectly fine. It does make it a bit more legible.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2405



More information about the security-dev mailing list