RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v8]

Andrey Turbanov github.com+741251+turbanoff at openjdk.java.net
Fri Feb 12 21:09:41 UTC 2021


On Mon, 8 Feb 2021 16:39:55 GMT, Julia Boes <jboes at openjdk.org> wrote:

>> The other security-related code changes look good to me.
>
> I've updated the issue summary to better reflect the changes, the PR summary should be renamed accordingly. 
> As mentioned earlier, have you run the tests for the affected areas? Here's some information on how to do that: http://openjdk.java.net/guide/#testing-the-jdk

I rebased my changes onto master. (commit 837bd8930d0a010110f1318b947c036609d3aa33)
and checked tier2 and tier3.
What I got:

    ==============================
    Test summary
    ==============================
       TEST                                              TOTAL  PASS  FAIL ERROR   
    >> jtreg:test/jdk:tier2                               3698  3690     6     2 <<
    >> jtreg:test/langtools:tier2                           12    11     1     0 <<
       jtreg:test/jaxp:tier2                               450   450     0     0   
    ==============================
    TEST FAILURE




    ==============================
    Test summary
    ==============================
       TEST                                              TOTAL  PASS  FAIL ERROR   
    >> jtreg:test/jdk:tier3                               1190  1188     2     0 <<
       jtreg:test/langtools:tier3                            0     0     0     0   
       jtreg:test/jaxp:tier3                                 0     0     0     0   
    ==============================
    TEST FAILURE


Failed tests:

     tier2:
     java/io/File/GetXSpace.java                                                                         Failed. Execution failed: `main' threw exception: java.nio.file.InvalidPathException: Illegal char <:> at index 0: :
     java/net/MulticastSocket/MulticastAddresses.java                                                    Failed. Execution failed: `main' threw exception: java.lang.Exception: 1 test(s) failed - see log file.
     java/net/MulticastSocket/SetLoopbackMode.java                                                       Failed. Execution failed: `main' threw exception: java.net.NoRouteToHostException: No route to host: no further information
     java/nio/file/Files/CopyAndMove.java                                                                Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: AtomicMoveNotSupportedException expected
     java/security/AccessController/DoPrivAccompliceTest.java                                            Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: 'user' found in stderr
     tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java                                        Failed. Execution failed: `main' threw exception: jdk.jpackage.test.Functional$ExceptionBox: java.lang.RuntimeException: 2 FAILED TESTS
     
     sun/security/tools/jarsigner/TimestampCheck.java                                                    Error. Agent error: java.lang.Exception: Agent 72 timed out with a timeout of 2400 seconds; check console log for any additional details
     sun/security/tools/keytool/DefaultOptions.java                                                      Error. Agent error: java.lang.Exception: Agent 77 timed out with a timeout of 480 seconds; check console log for any additional details
     
     jdk/jshell/ToolBasicTest.java                              Failed. Execution failed: `main' threw exception: java.lang.Exception: failures: 1
     
     tier3:
     sanity/client/SwingSet/src/SwingSet2DemoTest.java                                                                  Failed. Execution failed: `main' threw exception: java.lang.Exception: failures: 1
     sanity/client/SwingSet/src/ColorChooserDemoTest.java                                                               Failed. Execution failed: `main' threw exception: java.lang.Exception: failures: 1

-------------

PR: https://git.openjdk.java.net/jdk/pull/1853


More information about the security-dev mailing list