RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

[Andrew Haley]

On Mon, 15 Feb 2021 18:00:50 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 839:
>> 
>>> 837:           // The code unable to handle this, bailout.
>>> 838:           return -1;
>>> 839: #endif
>> 
>> This looks like a bug to me. The caller doesn't necessarily check the return value. See CallRuntimeNode::calling_convention.
>
> Hello, we have updated PR, now this bailout is used only by the code which can handle it (native wrapper generator), for the rest it will cause guarantee failed if this bailout is triggered

This is when passing a float, yes? In the case where we have more float arguments than n_float_register_parameters_c.
I don't understand why you think it's acceptable to bail in this case. Can you explain, please?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200