RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

Vladimir Kempik vkempik at openjdk.java.net
Tue Feb 16 14:09:54 UTC 2021


On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>>  - Add comments to WX transitions
>>    
>>    + minor change of placements
>>  - Use macro conditionals instead of empty functions
>>  - Add W^X to tests
>>  - Do not require known W^X state
>>  - Revert w^x in gtests
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 297:
> 
>> 295:           stub = SharedRuntime::handle_unsafe_access(thread, next_pc);
>> 296:         }
>> 297:       } else if (sig == SIGILL && nativeInstruction_at(pc)->is_stop()) {
> 
> Can we add a comment here describing what this case means?

This was added as part of this commit ( to linux_aarch64) - https://github.com/openjdk/jdk/commit/339d52600b285eb3bc57d9ff107567d4424efeb1

@gerard-ziemski  do we really want to add anything new here ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200



More information about the security-dev mailing list