RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v17]

Jim Laskey jlaskey at openjdk.java.net
Wed Feb 17 17:39:47 UTC 2021


On Sat, 13 Feb 2021 21:30:12 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added table of available algorithms.
>
> test/jdk/java/util/Random/RandomTestBsi1999.java line 227:
> 
>> 225:     static int checkRunStats(int[] stats) {
>> 226:        int runFailure = 0;
>> 227:            runFailure |= ((2267 <= stats[1]) || (stats[1] <= 2733)) ? 0 : 1;
> 
> 1. confusing formatting.
> 2. This condition is always `true`. Looks like `&&` should be used instead of `||`

Correct. Changed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1292



More information about the security-dev mailing list