RFR: 8211227: Inconsistent TLS protocol version in debug output [v2]

Evan Whelan ewhelan at openjdk.java.net
Thu Feb 18 20:37:59 UTC 2021


On Mon, 1 Feb 2021 19:41:09 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Evan Whelan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8211227: Re-wrote LoggingFormatConsistency to use local SSL server rather than an existing URL
>
> test/jdk/sun/security/ssl/SSLLogger/LoggingFormatConsistency.java line 50:
> 
>> 48: public class LoggingFormatConsistency {
>> 49:     public static void main(String[] args) throws Exception {
>> 50:         if (args.length == 0){
> 
> Please add a comment to explain when the test should be run with parameter.

Done! Thanks

> test/jdk/sun/security/ssl/SSLLogger/LoggingFormatConsistency.java line 36:
> 
>> 34: /*
>> 35:  * This test runs in another process so we can monitor the debug
>> 36:  * results.  The OutputAnalyzer must see correct debug output to return a
> 
> Suggestion:
> 
>  * results. The OutputAnalyzer must see correct debug output to return a

Blank space removed

-------------

PR: https://git.openjdk.java.net/jdk/pull/2331



More information about the security-dev mailing list