RFR: 8255867: SignatureScheme JSSE property does not preserve ordering in handshake messages [v3]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Mon Feb 22 21:39:41 UTC 2021


On Mon, 22 Feb 2021 21:28:57 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> This fix adjusts the SunJSSE provider's handling of the jdk.tls.[client | server].SignatureSchemes property and its effect on messages that assert the signature_algorithms and signature_algorithms_cert extensions, or supported_signature_algorithms vectors like those used in TLS 1.2 CertificateRequest messages.  With this change, the ordering of the signature algorithms in the property value will be preserved in the ordering as integer identifiers in the messages itself.  Prior to this fix the property algorithms will be asserted, but in the order as shown in the sun.security.ssl.SignatureAlgorithms enumeration.
>> 
>> This does not affect the default ordering of these signature schemes when the property is not given a value.
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8255867
>
> Jamil Nimeh has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix indentation, make test a derivation of SSLEngineTemplate

Looks good to me.  Thanks!

-------------

Marked as reviewed by xuelei (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2658



More information about the security-dev mailing list