RFR: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards

Ziyi Luo luoziyi at openjdk.java.net
Tue Feb 23 01:46:41 UTC 2021


On Tue, 23 Feb 2021 01:38:36 GMT, Ziyi Luo <luoziyi at openjdk.org> wrote:

> All of the "isAssignableFrom" checks in "engineGetKeySpec" appear to be backwards in Java's KeyFactorySpi.engineGetKeySpec implementations. In most cases, the requested KeySpec is equal to the concrete implementation so the inversion does not matter. But there are few cases, as presented in the added jtreg test, will cause unexpected behavior (e.g., ClassCastException rather than an InvalidKeySpecException). The fix is trivial.

Will change the branch and submit a new one

-------------

PR: https://git.openjdk.java.net/jdk/pull/2681


More information about the security-dev mailing list