RFR: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards

Ziyi Luo luoziyi at openjdk.java.net
Tue Feb 23 01:52:54 UTC 2021


All of the "isAssignableFrom" checks in "engineGetKeySpec" appear to be backwards in Java's KeyFactorySpi.engineGetKeySpec implementations. In most cases, the requested KeySpec is equal to the concrete implementation so the inversion does not matter. But there are few cases, as presented in the added jtreg test, will cause unexpected behavior (e.g., ClassCastException rather than an InvalidKeySpecException). The fix is trivial.

-------------

Commit messages:
 - 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards

Changes: https://git.openjdk.java.net/jdk/pull/2682/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2682&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8254717
  Stats: 112 lines in 15 files changed: 71 ins; 0 del; 41 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2682.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2682/head:pull/2682

PR: https://git.openjdk.java.net/jdk/pull/2682



More information about the security-dev mailing list