RFR: 8261880: Change nested classes in java.base to static nested classes where possible [v2]

Сергей Цыпанов github.com+10835776+stsypanov at openjdk.java.net
Thu Feb 25 11:07:47 UTC 2021


On Wed, 24 Feb 2021 08:50:36 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8261880: Remove static from declarations of Holder nested classes
>
> src/java.base/windows/classes/sun/nio/ch/PipeImpl.java line 67:
> 
>> 65:     private final SinkChannel sink;
>> 66: 
>> 67:     private static class Initializer
> 
> This one is okay to do.

Thanks for review! Could you review the rest of the code and approve this PR, if it's fine?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2589



More information about the security-dev mailing list