RFR: 8259535: ECDSA SignatureValue do not always have the specified length

Sean Mullan mullan at openjdk.java.net
Fri Feb 26 16:05:01 UTC 2021


On Fri, 26 Feb 2021 15:34:42 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureECDSA.java line 68:
>> 
>>> 66:      *
>>> 67:      * @param asn1Bytes
>>> 68:      * @param rawLen
>> 
>> You should add the same javadoc for these parameters as you did in ECDSAUtils.java.
>
> Well, it looks like a "style" to only list the param names without any explanation in this file and nearby files. Since the body of this method is only one line I assume people curious about the meaning of the parameters can just navigate to `ECDSAUtils.convertASN1toXMLDSIG` to read the description there.
> 
> Can we just keep it "clean"?

Ok, sounds reasonable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2550


More information about the security-dev mailing list