RFR: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed [v6]
Xue-Lei Andrew Fan
xuelei at openjdk.java.net
Sun Jan 10 06:56:17 UTC 2021
On Sun, 10 Jan 2021 06:40:49 GMT, Clive Verghese <cverghese at openjdk.org> wrote:
>> This PR aims to revert some more cases where SocketExceptions are improperly being wrapped as SSLException. Some work for this was done in [JDK-8235263](https://bugs.openjdk.java.net/browse/JDK-8235263), but that change did not cover all the cases.
>>
>> As it was mentioned in JDK-8235263, some applications rely on receiving SocketException to decide if the connection should be retried. An example of this would be Apache HTTP client. This PR should ideally fix https://issues.apache.org/jira/browse/HTTPCLIENT-2032
>
> Clive Verghese has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Address Review comments on transport shutdow and using SSLSocketTemplate
Looks good to me. Thank you!
-------------
Marked as reviewed by xuelei (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1968
More information about the security-dev
mailing list