RFR: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures [v5]

Martin Balao mbalao at openjdk.java.net
Wed Jan 20 12:59:50 UTC 2021


On Wed, 20 Jan 2021 06:00:41 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor documentation improvement in P11Mac regarding Cancel Operation
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java line 802:
> 
>> 800:                     System.arraycopy(padBuffer, 0, out, outOfs, k);
>> 801:                 } else {
>> 802:                     k = token.p11.C_DecryptFinal(session.id(), 0, out, outOfs,
> 
> Comment for line 638 apply here as well.

I agree, but the comment (in my opinion) should be right after the C_EncryptUpdate/C_DecryptUpdate call when doCancel is set to false.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1901



More information about the security-dev mailing list