RFR: 8256895: Add support for RFC 8954: Online Certificate Status Protocol (OCSP) Nonce Extension [v5]

Hai-May Chao hchao at openjdk.java.net
Wed Jan 20 21:37:11 UTC 2021


On Wed, 20 Jan 2021 20:57:49 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add nonce to the list of extensions
>
> src/java.base/share/classes/sun/security/provider/certpath/RevocationChecker.java line 762:
> 
>> 760:                             }
>> 761: 
>> 762:                             tmpExtensions.add(nonceExt);
> 
> If you only need the nonce, you could use List.of and save a little bit of memory, ex:
> 
>                             if (ocspExtensions.size() > 0) {
>                                 tmpExtensions = new ArrayList<Extension>(ocspExtensions);
>                                 tmpExtensions.add(nonceExt);
>                             } else {
>                                 tmpExtensions = List.of(nonceExt);
>                             }

Thanks for the review. Updated as suggested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2039


More information about the security-dev mailing list