RFR: 8258915: Temporary buffer cleanup [v2]

Weijun Wang weijun at openjdk.java.net
Fri Jan 22 14:54:45 UTC 2021


On Fri, 22 Jan 2021 07:44:41 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - rsa
>>  - Merge
>>  - 8258915: More temporary buffer cleanup
>>    
>>    8258915: More temporary buffer cleanup
>
> src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 234:
> 
>> 232:                 encodedKey = out.toByteArray();
>> 233:                 // Copy the actual bytes
>> 234:                 System.arraycopy(key, 0, encodedKey, encodedKey.length - key.length, key.length);
> 
> I think this can now be updated with the newer DerValue.wrap(....) then DerValue.clear() approach?

Good idea!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2070



More information about the security-dev mailing list