RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

[Phil Race]

On Mon, 25 Jan 2021 21:18:59 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Hello
>> I believe it was a workaround for issues with xcode 12.2 in early beta days.
>> Those issues were fixed later in upstream jdk, so most likely we need to remove these workarounds.
>
> It seems these workarounds are still needed:
> 
> jdk/src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m:300:39: error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS 10.14 [-Werror,-Wdeprecated-declarations]
>                         bitmapFormat: NSAlphaFirstBitmapFormat | NSAlphaNonpremultipliedBitmapFormat
>                                       ^~~~~~~~~~~~~~~~~~~~~~~~
>                                       NSBitmapFormatAlphaFirst
> 
> jdk/src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m:438:34: error: 'NSBorderlessWindowMask' is deprecated: first deprecated in macOS 10.12 [-Werror,-Wdeprecated-declarations]
>                       styleMask: NSBorderlessWindowMask
>                                  ^~~~~~~~~~~~~~~~~~~~~~
>                                  NSWindowStyleMaskBorderless

Are you doing something somewhere to change the target version of macOS or SDK ? I had no such problem.
I think we currently target a macOS 10.9 and if you are changing that it would need discussion.
If you are changing it only for Mac ARM that may make more sense .. 

And these appear to be just API churn by Apple
NSAlphaFirstBitmapFormat is replaced by NSBitmapFormatAlphaFirst

https://developer.apple.com/documentation/appkit/nsbitmapformat/nsbitmapformatalphafirst?language=objc

NSBorderlessWindowMask is replaced by NSWindowStyleMask

https://developer.apple.com/documentation/appkit/nswindowstylemask?language=occ

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200