RFR: 8270317: Large Allocation in CipherSuite

[Clive Verghese]

On Thu, 22 Jul 2021 00:11:56 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Updated Benchmarks in Throughput mode 
>> 
>> ### Current 
>> 
>> Benchmark                                                        (cipherSuite)   Mode  Cnt     Score     Error   Units
>> CipherSuiteBench.benchmarkCipherSuite                   TLS_AES_256_GCM_SHA384  thrpt   25  8050.787 ? 232.335  ops/ms
>> CipherSuiteBench.benchmarkCipherSuite  TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384  thrpt   25  8165.124 ? 283.718  ops/ms
>> CipherSuiteBench.benchmarkCipherSuite      TLS_DHE_DSS_WITH_AES_128_CBC_SHA256  thrpt   25  7827.758 ? 293.311  ops/ms
>> CipherSuiteBench.benchmarkCipherSuite         TLS_DHE_RSA_WITH_AES_256_CBC_SHA  thrpt   25  7768.286 ? 181.399  ops/ms
>> 
>> 
>> ### ArrayList
>> 
>> Benchmark                                                        (cipherSuite)   Mode  Cnt    Score   Error   Units
>> CipherSuiteBench.benchmarkCipherSuite                   TLS_AES_256_GCM_SHA384  thrpt   25  100.626 ? 0.294  ops/us
>> CipherSuiteBench.benchmarkCipherSuite  TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384  thrpt   25   32.793 ? 0.804  ops/us
>> CipherSuiteBench.benchmarkCipherSuite      TLS_DHE_DSS_WITH_AES_128_CBC_SHA256  thrpt   25   21.162 ? 0.217  ops/us
>> CipherSuiteBench.benchmarkCipherSuite         TLS_DHE_RSA_WITH_AES_256_CBC_SHA  thrpt   25   18.220 ? 0.903  ops/us
>> 
>> 
>> ### Hashmap
>> 
>> Benchmark                                                        (cipherSuite)   Mode  Cnt   Score   Error   Units
>> CipherSuiteBench.benchmarkCipherSuite                   TLS_AES_256_GCM_SHA384  thrpt   25  63.836 ? 4.517  ops/us
>> CipherSuiteBench.benchmarkCipherSuite  TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384  thrpt   25  69.983 ? 8.965  ops/us
>> CipherSuiteBench.benchmarkCipherSuite      TLS_DHE_DSS_WITH_AES_128_CBC_SHA256  thrpt   25  68.091 ? 7.404  ops/us
>> CipherSuiteBench.benchmarkCipherSuite         TLS_DHE_RSA_WITH_AES_256_CBC_SHA  thrpt   25  52.831 ? 4.317  ops/us
>> 
>> 
>> I am currently looking into the JFR profiles to identify why there is a difference in benchmarks with regards the different cipher suits in the current version vs the arraylist.
>
>> Updated Benchmarks in Throughput mode
> 
> Thank you very much for the update.
> 
>> I am currently looking into the JFR profiles to identify why there is a difference in benchmarks with regards the different cipher suits in the current version vs the arraylist.
> 
> I guess the garbage collection plays a role here.

Hi @XueleiFan, Thank you for the feedback. I have update the pull requests addressing your comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4783