RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v4]

Anthony Scarpino ascarpino at openjdk.java.net
Thu Jul 22 19:18:08 UTC 2021


On Fri, 16 Jul 2021 00:09:37 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Smita Kamath has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated AES-GCM intrinsic to match latest Java Code
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 611:
> 
>> 609:                         outOfs + len);
>> 610:                 ghash.update(ct, ctOfs, segments);
>> 611:                 ctOfs = len;
> 
> This does not look right when the initial value of ctOfs != 0.

Yeah that doesn't look right

-------------

PR: https://git.openjdk.java.net/jdk/pull/4019



More information about the security-dev mailing list