RFR: 8270317: Large Allocation in CipherSuite [v4]

Clive Verghese cverghese at openjdk.java.net
Fri Jul 23 16:52:42 UTC 2021


On Fri, 23 Jul 2021 05:52:25 GMT, djelinski <github.com+30433125+djelinski at openjdk.org> wrote:

>> Clive Verghese has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add blank space before and after the for loop
>
> src/java.base/share/classes/sun/security/ssl/CipherSuite.java line 971:
> 
>> 969: 
>> 970:             boolean found = false;
>> 971:             for (CipherSuite cs : allowedCipherSuites) {
> 
> We can avoid this loop; look up the cipher by name first (`cs = nameOf(name)`), then check for supported protocols.
> Other than that, LGTM.

Thank you for the feedback. I have updated the loop accordingly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4783


More information about the security-dev mailing list