RFR: 8270946: X509CertImpl.getFingerprint should not return the empty String [v2]

Sean Mullan mullan at openjdk.java.net
Mon Jul 26 17:03:12 UTC 2021


On Mon, 26 Jul 2021 14:12:48 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Not sure what you mean by inline. Do you mean use an anonymous inner class instead of a lambda for the `Function` argument to `ConcurrentHashMap.computeIfAbsent`? Note that `getFingerprintInternal` calls `this.getEncodedInternal` so it cannot be static.
>
> It's "inline" in code refactoring. I was thinking about moving the body of the current `getFingerprintInternal` into its only caller above which is also an instance method. IMO, the other `getFingerPrint` on line 1936 is more internal.

Ok, check out the latest commit to see if it is clearer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4891



More information about the security-dev mailing list