RFR: 8255557: Decouple GCM from CipherCore [v4]

Valerie Peng valeriep at openjdk.java.net
Tue Jun 1 19:47:47 UTC 2021


On Fri, 21 May 2021 04:15:44 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 628:
>> 
>>> 626:         }
>>> 627: 
>>> 628:         int mergeBlock(byte[] buffer, int bufOfs, byte[] in, int inOfs,
>> 
>> Can be made 'static'? No javadoc for this one, maybe move the javadoc for the other one up and use "Methods" in the javadoc to cover both?
>
> I just copied it and made a slight change to explain the difference

Sure.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list