RFR: 8255557: Decouple GCM from CipherCore [v4]

Anthony Scarpino ascarpino at openjdk.java.net
Wed Jun 2 17:11:42 UTC 2021


On Thu, 20 May 2021 19:46:51 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 1163:
> 
>> 1161:                     r = doUpdate(buffer, 0, bufLen, out, outOfs);
>> 1162:                     bufLen -= r;
>> 1163:                     inOfs += r;
> 
> Would bufLen >= blockSize? Regardless, 'inOfs' should not be touched as 'in' is not used in the above doUpdate() call.

removing it

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list