RFR: 8255557: Decouple GCM from CipherCore [v5]

Anthony Scarpino ascarpino at openjdk.java.net
Wed Jun 2 20:31:50 UTC 2021


On Mon, 24 May 2021 20:33:33 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments update
>
> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java line 673:
> 
>> 671: 
>> 672:         // Test update-update-doFinal with byte arrays and preset data sizes
>> 673:         t = new GCMBufferTest("AES/GCM/NoPadding",
> 
> This change seems un-necessary? Why separating the declaration to line 631?

I just decided it was better to have the declaration that is used more than once at the top.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list