RFR: 8267485: Remove the dependency on SecurityManager in JceSecurityManager.java [v3]
Sean Mullan
mullan at openjdk.java.net
Thu Jun 3 14:37:46 UTC 2021
On Wed, 2 Jun 2021 23:15:46 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> The JceSecurityManager is currently a subclass of java.security.SecurityManager. Now that JEP 411 has been integrated, this class should be updated to no longer subclass SecurityManager.
>>
>> The only reason for using SecurityManager to easily get the Class Context (call stack), but we can achieve the same effect by using the JDK 9 API java.lang.StackWalkeer. None of the other SecurityManager API are used.
>>
>> I have run mach5 tier1/tier2 plus --test jck:api/java_security,jck:api/javax_crypto,jck:api/javax_net,jck:api/javax_security,jck:api/org_ietf,jck:api/javax_xml/crypto with all green.
>
> Bradford Wetmore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>
> - Address codereview comments
> - Merge branch 'master' into JDK-8267485
> - Merge branch 'master' into JDK-8267485
> - Merge branch 'master' into JDK-8267485
> - Replace missing annotation
> - Merge branch 'master' into JDK-8267485
> - Updated copyright date.
> - 8267485: Remove the dependency on SecurityManager in JceSecurityManager.java
I would remove line 44 from the comments as it is no longer applicable:
* <p>Note that this security manager is never installed, only instantiated.
Also, you may want to rename this class to something other than JceSecurityManager to avoid future confusion, maybe "JcePolicyManager".
-------------
PR: https://git.openjdk.java.net/jdk/pull/4150
More information about the security-dev
mailing list