RFR: 8255557: Decouple GCM from CipherCore [v8]
Anthony Scarpino
ascarpino at openjdk.java.net
Thu Jun 3 16:04:19 UTC 2021
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use CipherCore, and AESCrypt to handle it's buffers and other objects. It is also a major code redesign limits the amount of data copies and make some performance-based decisions.
>
> Thanks
>
> Tony
Anthony Scarpino has updated the pull request incrementally with three additional commits since the last revision:
- missed resultLen and undo decrypt heap hasarray check
- code review comments
- fix
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4072/files
- new: https://git.openjdk.java.net/jdk/pull/4072/files/d230e665..c5e19250
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4072&range=07
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4072&range=06-07
Stats: 199 lines in 3 files changed: 20 ins; 123 del; 56 mod
Patch: https://git.openjdk.java.net/jdk/pull/4072.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4072/head:pull/4072
PR: https://git.openjdk.java.net/jdk/pull/4072
More information about the security-dev
mailing list