RFR: 8255557: Decouple GCM from CipherCore [v8]

Anthony Scarpino ascarpino at openjdk.java.net
Thu Jun 3 20:49:13 UTC 2021


On Thu, 3 Jun 2021 19:13:00 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - missed resultLen and undo decrypt heap hasarray check
>>  - code review comments
>>  - fix
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 84:
> 
>> 82:     private static final int MAX_BUF_SIZE = Integer.MAX_VALUE;
>> 83:     // data size when buffer is divided up to aid in intrinsics
>> 84:     private static final int TRIGGERLEN = 4096;  // 64k
> 
> nit: comment should be 4k?

Ack.. I changed it to test something and forgot to change it back.. I'll put it back to 64k with the merge-conflict

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list