RFR: 8255557: Decouple GCM from CipherCore [v8]
Valerie Peng
valeriep at openjdk.java.net
Thu Jun 3 22:42:11 UTC 2021
On Thu, 3 Jun 2021 16:04:19 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use CipherCore, and AESCrypt to handle it's buffers and other objects. It is also a major code redesign limits the amount of data copies and make some performance-based decisions.
>>
>> Thanks
>>
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with three additional commits since the last revision:
>
> - missed resultLen and undo decrypt heap hasarray check
> - code review comments
> - fix
Update changes look good. Just a nit and the issue with originalOut remains.
Thanks,
Valerie
-------------
Marked as reviewed by valeriep (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4072
More information about the security-dev
mailing list