RFR: 8255557: Decouple GCM from CipherCore [v9]
Anthony Scarpino
ascarpino at openjdk.java.net
Fri Jun 4 06:51:35 UTC 2021
> Hi,
>
> I need a review of this rather large change to GCM. GCM will no longer use CipherCore, and AESCrypt to handle it's buffers and other objects. It is also a major code redesign limits the amount of data copies and make some performance-based decisions.
>
> Thanks
>
> Tony
Anthony Scarpino has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
- merge, and a few nits
- Merge branch 'master' into perfphase1
- left 4k test length for trigger
- missed resultLen and undo decrypt heap hasarray check
- code review comments
- fix
- Remove GCTR reset() calls because GCTR is released after the operation
some variable name consistency
other small cleanup
- Review comments update
- Review comments update
- Fix perf problem by reorganizing doLastBlock()
- ... and 19 more: https://git.openjdk.java.net/jdk/compare/b9558655...d84d302b
-------------
Changes: https://git.openjdk.java.net/jdk/pull/4072/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4072&range=08
Stats: 2783 lines in 15 files changed: 1309 ins; 767 del; 707 mod
Patch: https://git.openjdk.java.net/jdk/pull/4072.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4072/head:pull/4072
PR: https://git.openjdk.java.net/jdk/pull/4072
More information about the security-dev
mailing list