Integrated: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries

[Maurizio Cimadamore]

On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch overhauls the library loading mechanism used by the Foreign Linker API. We realized that, while handy, the *default* lookup abstraction (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms.
> 
> This patch replaces `LibraryLookup` with a simpler `SymbolLookup` abstraction, a functional interface. Crucially, `SymbolLookup` does not concern with library loading, only symbol lookup. For this reason, two factories are added:
> 
> * `SymbolLookup::loaderLookup` - which obtains a lookup that can be used to lookup symbols in libraries loaded by current loader
> * `CLinker::systemLookup` - a more stable replacement for the *default* lookup, which looks for symbols in libc.so (or its equivalent in other platforms). The contents of this lookup are unspecified.
> 
> Both factories are *restricted*, so they can only be called when `--enable-native-access` is set.

This pull request has now been integrated.

Changeset: 59a539fe
Author:    Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/59a539fef12dec6ba8af8a41000829402e7e9b72
Stats:     1351 lines in 47 files changed: 626 ins; 621 del; 104 mod

8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries

Reviewed-by: jvernee, psandoz

-------------

PR: https://git.openjdk.java.net/jdk/pull/4316