RFR: 8268873: Unnecessary Vector usage in java.base

Сергей Цыпанов github.com+10835776+stsypanov at openjdk.java.net
Wed Jun 16 09:22:47 UTC 2021


On Mon, 14 Jun 2021 11:34:50 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed.
> I checked only places where `Vector` was used as local variable.

I've filed https://bugs.openjdk.java.net/browse/JDK-8268873 for this, just put `/issue 8268873` as a comment for this ticket to bind it to the issue

src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line 154:

> 152:             while (tokenizer.hasMoreTokens())
> 153:                 v.add(tokenizer.nextToken());
> 154:             ciphers = new String [v.size()];

Looks like this whole `else` block can be simplified to `ciphers = cipherString.split(",");`

-------------

PR: https://git.openjdk.java.net/jdk/pull/4482



More information about the security-dev mailing list