RFR: 8268873: Unnecessary Vector usage in java.base

Сергей Цыпанов github.com+10835776+stsypanov at openjdk.java.net
Thu Jun 17 08:20:15 UTC 2021


On Wed, 16 Jun 2021 09:49:17 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line 154:
>> 
>>> 152:             while (tokenizer.hasMoreTokens())
>>> 153:                 v.add(tokenizer.nextToken());
>>> 154:             ciphers = new String [v.size()];
>> 
>> Looks like this whole `else` block can be simplified to `ciphers = cipherString.split(",");`
>
> It's not a drop-in replacement. Result is different for some Strings. For example for `,  A`
> I would prefer to preserve existing behavior under this cleanup.

Then let's keep it as is

-------------

PR: https://git.openjdk.java.net/jdk/pull/4482



More information about the security-dev mailing list