RFR: 8268427: Improve AlgorithmConstraints:checkAlgorithm performance [v2]

Dongbo He dongbohe at openjdk.java.net
Thu Jun 17 12:08:13 UTC 2021


On Thu, 17 Jun 2021 04:43:27 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Dongbo He has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make getAlgorithms() method return a Set
>
> src/java.base/share/classes/sun/security/util/AbstractAlgorithmConstraints.java line 72:
> 
>> 70:             algorithmsInProperty = property.split(",");
>> 71:             for (int i = 0; i < algorithmsInProperty.length; i++) {
>> 72:                 algorithmsInProperty[i] = algorithmsInProperty[i].trim().toLowerCase(Locale.ENGLISH);
> 
> Is it possible to keep the current behavior that the property could be sensitive?  It may be not desired to allow "keysize" for "keySize" spec in the property.

If we keep property sensitive, we may need to use TreeSet. I have updated the PR with TreeSet. Fortunately, the performance hasn't changed much.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4424



More information about the security-dev mailing list