RFR: 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE
Jack Hartstein
github.com+44308314+jackh2000 at openjdk.java.net
Wed Jun 23 20:25:47 UTC 2021
8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE
-------------
Commit messages:
- 8217408: Reduce storage of duplicate identifiers in TLS vectors in SunJSSE
- Changed ClientHello compression consumer loop to index by 1 instead of 2 (bytes vs shorts), and SupportedVersionsExt consumer get length to getInt8 vs getInt16
- removed duplicate filtering in producer side constructors for AlpnExt, CertSignAlgsExt, ServNameExt, SigAlgsExt, SupGrpsExt, SupVersExt. Removed unnecessary intermediary array in consumer methods for SigAlgsExt, SupGrpsExt, SupVersExt. Improved byte array handling for compression methods in ClientHelloMessage. Overall code cleanup
- reverted changes to produce method in AlpnExtension, CertSignAlgsExtension, SignatureAlgorithmsExtension, SupportedGroupsExtension, and SupportedVersionsExtension
- added duplicate filtering to CertSignAlgsExtension, added first pass attempt at filtering compression methods to ClientHello. Added tests for duplicates in compression methods, CertSignAlgs, and ServerNames to test file.
- added stream based duplicate fixes to SignatureAlgorithmExtension, SupportedGroupsExtension, and minor changes to previous fix on SupportedVersionsExtension. Added tests for SupGrp and SigAlg extensions to test file.
- modified test file to check ALPNs, added duplicate check to SupportedGroupsSpec
- formatting, adding ALPN check to test file
- implemented IntStream duplicate clearing for ClientHello ciphersuites, SupportedVersionsExtensions, Stream duplicate clearing implementation for AlpnExtension
- formatting fixes
- ... and 2 more: https://git.openjdk.java.net/jdk/compare/51e8201e...83a887d1
Changes: https://git.openjdk.java.net/jdk/pull/4577/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4577&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8217408
Stats: 660 lines in 9 files changed: 597 ins; 11 del; 52 mod
Patch: https://git.openjdk.java.net/jdk/pull/4577.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4577/head:pull/4577
PR: https://git.openjdk.java.net/jdk/pull/4577
More information about the security-dev
mailing list