RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v7]

[Alan Bateman]

On Tue, 4 May 2021 12:01:44 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessChecker.java line 34:
>> 
>>> 32: import java.util.Set;
>>> 33: 
>>> 34: public final class IllegalNativeAccessChecker {
>> 
>> Are you sure about the name of the this class? It doesn't do any checking and it's not concerned with "illegal native access" either, instead it just provides access to the names of modules that have been granted native access.
>
> I've decided to drop this class and move the logic in ModuleBootstrap. To handle unnamed modules, I had to piggy back on the special static ALL_UNNAMED module and set the flag there when decoding the command line option. This seems to be consistent with what is done in other areas.

Good, this looks much simpler now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3699