RFR: 8164804: sun/security/ssl/SSLSocketImpl/CloseSocket.java makes not reliable time assumption [v3]

Fernando Guallini fguallini at openjdk.java.net
Tue May 11 13:58:28 UTC 2021


> test sun/security/ssl/SSLSocketImpl/CloseSocket.java verifies the behavior when a server closes the socket connection during a handshake. The server was waiting a fixed 100ms before closing it, but there was no guarantee that the client started the handshake before or during that time frame 
> 
> With this changeset, the server is checking whether the client thread has initiated handshake, and retrying if needed after waiting a short time. In addition, the test is now reusing SSLSocketTemplate to simplify sockets configuration and client/server synchronization

Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:

  added thread stack comment in test

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3856/files
  - new: https://git.openjdk.java.net/jdk/pull/3856/files/300ac1ad..ea50ddeb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3856&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3856&range=01-02

  Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3856.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3856/head:pull/3856

PR: https://git.openjdk.java.net/jdk/pull/3856



More information about the security-dev mailing list