RFR: 8255557: Decouple GCM from CipherCore

Anthony Scarpino ascarpino at openjdk.java.net
Mon May 17 18:22:28 UTC 2021


I need a review of this rather large change to GCM.  GCM will no longer use CipherCore, and AESCrypt  to handle it's buffers and other objects.  It is also a major code redesign limits the amount of data copies and make some performance-based decisions.




Commit messages:
 - Update
 - Update, passing tests
 - Re-add missing intrinsic trigger methods
 - update flush
 - reverting
 - reverting
 - Revert "direct bytebuffer GHASH intrinsic"
 - Revert "Splitting perfghash and perfphase1"
 - undo debugging
 - remove intrinsic from GHASH
 - ... and 6 more: https://git.openjdk.java.net/jdk/compare/794cefe8...f52d57d6

Changes: https://git.openjdk.java.net/jdk/pull/4072/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4072&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8255557
  Stats: 2793 lines in 15 files changed: 1403 ins; 695 del; 695 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4072.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4072/head:pull/4072

PR: https://git.openjdk.java.net/jdk/pull/4072

More information about the security-dev mailing list