RFR: 8265462: Handle multiple slots in the NSS Internal Module from SunPKCS11's Secmod [v2]

Martin Balao mbalao at openjdk.java.net
Tue May 18 04:03:16 UTC 2021


> Hi,
> 
> Please find in this PR a proposal to fix JDK-8265462 [1].
> 
> With this fix, OpenJDK will only use the known slot IDs for the NSS Internal Module. If the NSS Internal Module has more slots (for example, as a result of an initialization sequence such as the one triggered from the libnsssysinit.so library), they will be ignored. The goal is to handle multiple-slots scenarios while keeping OpenJDK's previous behavior.
> 
> No regressions observed in the jdk/sun/security/pkcs11 tests category.
> 
> A new regression test was not added as part of this changeset because of its complexity. It would depend on a specific NSS configuration, or the NSS library would need to be mocked. I've done manual testing in my environment and JDK-8265462 [1] has further information about it.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8265462

Martin Balao has updated the pull request incrementally with one additional commit since the last revision:

  Documentation improvements and minor reordering

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3661/files
  - new: https://git.openjdk.java.net/jdk/pull/3661/files/ae8b2d18..c83c98d6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3661&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3661&range=00-01

  Stats: 20 lines in 3 files changed: 13 ins; 5 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3661.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3661/head:pull/3661

PR: https://git.openjdk.java.net/jdk/pull/3661



More information about the security-dev mailing list