Integrated: 8265462: Handle multiple slots in the NSS Internal Module from SunPKCS11's Secmod

Martin Balao mbalao at openjdk.java.net
Tue May 18 22:37:43 UTC 2021


On Fri, 23 Apr 2021 19:32:35 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> Please find in this PR a proposal to fix JDK-8265462 [1].
> 
> With this fix, OpenJDK will only use the known slot IDs for the NSS Internal Module. If the NSS Internal Module has more slots (for example, as a result of an initialization sequence such as the one triggered from the libnsssysinit.so library), they will be ignored. The goal is to handle multiple-slots scenarios while keeping OpenJDK's previous behavior.
> 
> No regressions observed in the jdk/sun/security/pkcs11 tests category.
> 
> A new regression test was not added as part of this changeset because of its complexity. It would depend on a specific NSS configuration, or the NSS library would need to be mocked. I've done manual testing in my environment and JDK-8265462 [1] has further information about it.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8265462

This pull request has now been integrated.

Changeset: bdbe23b9
Author:    Martin Balao <mbalao at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/bdbe23b9cb6151c81a4de675e629b0a42f00640d
Stats:     167 lines in 3 files changed: 135 ins; 3 del; 29 mod

8265462: Handle multiple slots in the NSS Internal Module from SunPKCS11's Secmod

Reviewed-by: valeriep

-------------

PR: https://git.openjdk.java.net/jdk/pull/3661



More information about the security-dev mailing list