RFR: 8255557: Decouple GCM from CipherCore [v4]

Anthony Scarpino ascarpino at openjdk.java.net
Wed May 19 20:21:23 UTC 2021


> Hi,
> 
> I need a review of this rather large change to GCM.  GCM will no longer use CipherCore, and AESCrypt  to handle it's buffers and other objects.  It is also a major code redesign limits the amount of data copies and make some performance-based decisions.
> 
> Thanks
> 
> Tony

Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:

  Fix perf problem by reorganizing doLastBlock()

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4072/files
  - new: https://git.openjdk.java.net/jdk/pull/4072/files/4a2e35c1..e75926e8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4072&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4072&range=02-03

  Stats: 259 lines in 1 file changed: 70 ins; 106 del; 83 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4072.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4072/head:pull/4072

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list