RFR: 8255557: Decouple GCM from CipherCore [v3]

Anthony Scarpino ascarpino at openjdk.java.net
Thu May 20 21:17:34 UTC 2021


On Wed, 19 May 2021 18:17:27 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 259:
> 
>> 257:     @Override
>> 258:     protected void engineInit(int opmode, Key key,
>> 259:         AlgorithmParameterSpec params, SecureRandom random)
> 
> The specified "random" is not saved to internal "random". Perhaps an oversight?

Yeah, I changed this code long ago, i suspect I didn't realize engineGetParameters() used it

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list