RFR: 8255557: Decouple GCM from CipherCore [v4]

Anthony Scarpino ascarpino at openjdk.java.net
Thu May 20 23:20:40 UTC 2021


On Tue, 18 May 2021 21:56:38 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix perf problem by reorganizing doLastBlock()
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 59:
> 
>> 57: final class GaloisCounterMode extends FeedbackCipher {
>> 58: 
>> 59:     static int DEFAULT_TAG_LEN = AES_BLOCK_SIZE;
> 
> Hmm, for the same reason as the DEFAULT_IV_LEN, you will probably need a DEFAULT_TAG_LEN. Otherwise, how do you know what the default tag length is after several Cipher.init() calls?

Yes, I can see where running init() on a previously used object can use the old tag

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list