RFR: 8255557: Decouple GCM from CipherCore [v3]

Anthony Scarpino ascarpino at openjdk.java.net
Fri May 21 02:41:31 UTC 2021


On Tue, 18 May 2021 22:23:11 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 225:
> 
>> 223:     }
>> 224: 
>> 225:     SecureRandom random = null;
> 
> Is this field used? I didn't find any assignment. If it's needed, can you please move it to where the rest of fields are?

As part of your earlier comment, I realized it should be used when the user specifies a random.  I also moved it up to the top

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072


More information about the security-dev mailing list