RFR: 8255557: Decouple GCM from CipherCore [v2]

Valerie Peng valeriep at openjdk.java.net
Fri May 21 02:54:53 UTC 2021


On Mon, 17 May 2021 21:58:48 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - review comment updates
>>  - Fixed the lack of overlap detection with GCMEncrypt.update()
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 54:
> 
>> 52:  * @since 1.8
>> 53:  */
>> 54: final class GCTR extends CounterMode implements GCM {
> 
> Not sure if this really needs to implements GCM?

Well, I see how you use this GCM interface now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4072



More information about the security-dev mailing list