RFR: 8267521: Post JEP 411 refactoring: maximum covering > 50K [v3]

Weijun Wang weijun at openjdk.java.net
Mon May 24 21:51:32 UTC 2021


On Mon, 24 May 2021 09:00:07 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> Thanks for taking in my suggestions for FtpClient. I have also reviewed the changes to java.util.logging and JMX. I wish there was a way to handle doPrivileged returning void more nicely. Maybe component maintainers will be able to deal with them on a case-by-case basis later on.

Assigning to a useless "dummy" variable looks ugly. Extracting the call to a method might make it faraway from its caller. In L114 of `FtpClient.java` I managed to invent a return value and I thought it was perfect. But you said it's "a bit strange". :-(

-------------

PR: https://git.openjdk.java.net/jdk/pull/4138


More information about the security-dev mailing list