RFR: 8275811 Incorrect instance to dispose

Daniel Jeliński duke at openjdk.java.net
Mon Nov 1 14:25:10 UTC 2021


On Sun, 24 Oct 2021 04:58:45 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> Did you want to cover the update for line 222 at OutputRecord.java as well?
>
>> After reviewing the scope of changes to fix writeCipher disposal I decided to remove it entirely. It would probably be a nice follow-up enhancement, but I'm not confident I'd implement it correctly on the first try, so I'd rather not introduce it in a bugfix PR. @XueleiFan is that acceptable to you?
>> 
> I'm not sure of the removal.  Please hold on the integration, and I will have a further look if I have cycles.

Hi @XueleiFan,
I updated the PR to dispose old write ciphers after encrypting the last record. Tests in jdk_security passed. Let me know what you think.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6084



More information about the security-dev mailing list